Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-12077) Respect rich_data setting in base context #9471

Merged
merged 5 commits into from
Sep 24, 2024

Commits on Sep 6, 2024

  1. (PUP-12077) Respect rich_data setting in base context

    Since Puppet 6.0 "datafication" has inspected the context for the value
    of rich_data. However, in only some code paths does the value in the
    context get overridden with a value taken from the settings. This means
    in some cases the rich_data value will always be true or always be
    false, regardless of how the user has configured the rich_data setting.
    And, in the case the simply calling `to_data_hash` on a resource the
    rich_data value will always be false.
    
    This updates the base_context to set rich_data to the settings value,
    ensuring that the default value for rich_data in the context is the
    value users have set.
    
    Additional changes are primarily where tests still assumed the default
    value of rich_data was false, with one exception - YAML serialization in
    the resource application will break if the internal rich_data `__pcore`
    values are output. This forces rich_data to be false for that code path
    in the resource application.
    
    Fixes GH puppetlabs#9470
    justinstoller committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    91961bc View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    3ee2564 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b06a0de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f61d16 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8633e94 View commit details
    Browse the repository at this point in the history