Add missing return #9413
Merged
Add missing return #9413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubocop 1.65.0 fixed false negatives for Lint/Void, which highlighted some bugs where the guard clauses weren't doing anything. Commit 01db61e moved code from runtime3_support to runtime3_resource_support: * Runtime3Support is modified to use Runtime3ResourceSupport instead of directly containing the methods for resource search and creation. But the resource_to_ptype method was copied instead of moved. So delete it from Runtime3Support.
mhashizume
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocop 1.65.0 fixed false negatives for Lint/Void, which highlighted some bugs where the guard clauses weren't doing anything.
Commit 01db61e moved code from runtime3_support to runtime3_resource_support:
But the
resource_to_ptypemethod was copied instead of moved. So delete it from Runtime3Support.This should not be backported to 7.x, since we're constrained to an older version:
puppet/Gemfile
Line 55 in 46e88b4