Drop specs when building gem #9249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously our key and cert test fixtures were shipped in the gem, which triggered security scanners. This deletes the `spec` directory from each platform specific gem and reduces the size of each gem by about 1MB when using the `bundle exec rake package:gem` task: Before: ``` $ ls -la pkg/puppet-8.4.0.178.gem -rw-rw-r-- 1 josh 1.5M Feb 9 11:21 pkg/puppet-8.4.0.178.gem ``` After: ``` $ ls -la pkg/puppet-8.4.0.177.gem -rw-rw-r-- 1 josh 2.8M Feb 9 11:21 pkg/puppet-8.4.0.177.gem ``` For reasons described in PA-5400 we don't currently use `gem build .gemspec` to build puppet gems. No changes are needed to the .gemspec or Gemfile, because they both include the content from project_data.yaml.
joshcooper
force-pushed
the
drop_specs
branch
from
447e1ae
to
107a8e5
Compare
bastelfreak
approved these changes
Feb 9, 2024
mhashizume
approved these changes
Feb 9, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9249-to-7.x origin/7.x
cd .worktree/backport-9249-to-7.x
git checkout -b backport-9249-to-7.x
ancref=$(git merge-base a3e77e78b4952f8685c66a51bc98e12690bef4c2 107a8e572450c1a178b309e0e38c0d30796a068d)
git cherry-pick -x $ancref..107a8e572450c1a178b309e0e38c0d30796a068d |
|
@mhashizume I had to manually cherry-pick due to a conflict #9250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our key and cert test fixtures were shipped in the gem, which
triggered security scanners. This deletes the
specdirectory from eachplatform specific gem and reduces the size of each gem by about 1MB when
using the
bundle exec rake package:gemtask:Before:
After:
For reasons described in PA-5400 we don't currently use
gem build .gemspecto build puppet gems.
No changes are needed to the .gemspec or Gemfile, because they both
include the content from project_data.yaml.