Update Beaker result proxies on host object #9246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins please test this on redhat7-64a |
|
I'm testing this PR in an ad-hoc pipeline running Beaker 5 before marking it as ready for review. |
Previously in Beaker, you could use standalone stdout and stderr methods to access output from remote machines. These methods were deprecated in 2013 with voxpupuli/beaker@28b2510 and dropped entirely in voxpupuli/beaker@73a31c7. This commit updates any methods that were initially missed in the first pass of this work in commit 9f5f8e5.
mhashizume
force-pushed
the
PA-5022/main/addtl-beaker-methods
branch
from
b8b1296
to
c4d6e53
Compare
The assert_no_match method in Beaker was long deprecated then eventually removed altogether in voxpupuli/beaker@6282311 This commit updates assert_no_match to refute_match.
|
Passing with Beaker 5 and an updated version of beaker-puppet: https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/ad-hoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/1291/ |
|
This will need to be backported to 7.x as well. |
joshcooper
approved these changes
Feb 10, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9246-to-7.x origin/7.x
cd .worktree/backport-9246-to-7.x
git checkout -b backport-9246-to-7.x
ancref=$(git merge-base a3e77e78b4952f8685c66a51bc98e12690bef4c2 f2bec1a02e4daa8b5ee82af89b726d2b2547148a)
git cherry-pick -x $ancref..f2bec1a02e4daa8b5ee82af89b726d2b2547148a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in Beaker, you could use standalone stdout and stderr methods to access output from remote machines.
These methods were deprecated in 2013 with voxpupuli/beaker@28b2510 and dropped entirely in voxpupuli/beaker@73a31c7.
This commit updates any methods that were initially missed in the first pass of this work in commit 9f5f8e5.