Enable Additional Rubocop Extensions #9216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the rubocop-performance extension to Puppet as part of its Gemfile and .rubocop.yml configuration file. I've specified version 1.13.3 as it's the last version compatible with Ruby 2.5, which mirrors the version of Rubocop we have pinned and the version of Ruby that is targeted in the Rubocop configuration file. This commit also regenerates the Rubocop todo file and manually adds pending Performance cops to both the configuration and todo files.
This commit adds the rubocop-rake extension to Puppet's Gemfile and Rubocop configuration file, pinning it at 0.6.0 as it's the most recent version, and still supports Ruby 2.5 (which the rest of our Rubocop configuration is set up to support).
This commit adds the rubocop-rspec extension to Puppet's Gemfile and Rubocop configuration file, pinning it at 2.10.0 as it's the last version to support Ruby 2.5 (which the rest of our Rubocop configuration is set up to support). This work includes explicitly adding all pending RSpec cops to the Rubocop config file and enabling them.
joshcooper
reviewed
Jan 23, 2024
| Enabled: true | ||
|
|
||
| Performance/ReverseFirst: # new in 1.7 | ||
| Enabled: true |
There was a problem hiding this comment.
Some of these cops would be good to fix like the RedundantSortBlock. Should they go in the todo file instead?
There was a problem hiding this comment.
My understanding is that the pending cops (including RedundantSortBlock) that I've added here in .rubocop.yml are enabled but found no offenses.
I wanted to specify pending cops in .rubocop.yml that didn't require any changes so that we wouldn't need to come back later to enable them.
joshcooper
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the performance, Rake, and RSpec Rubocop extensions and configures them in the Rubocop configuration and todo files. This does not involve any code changes.
Note that I have pinned all of these gems at the last version that supported Ruby 2.5, matching with where we have Rubocop itself pinned and the version of Ruby we target in the Rubocop configuration file. We will update this in a future PR.