Clean up SystemD tests #9213
Merged
Clean up SystemD tests #9213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Removes internal spacing from array brackets. - Shortens long arrays using ranges and string-array and symbol-array literals.
In e660355, we added an additional test for nonexistent services, including a test for a Debian-specific code path that runs invoke-rc.d. Because this code path is only invoked on Debian systems, this test would regularly fail for any other platforms. This commit mocks the os.family fact for the nonexistent services tests.
cthorn42
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
os.familyfact in the SystemD nonexistent services tests to allow the test to run the Debian-specific code path, regardless of which platform the test is run on.