SystemD and Windows resources when not resource found will now return error #9175

cthorn42 · 2023-11-29T22:02:14Z

Previously when Windows or SystemD attempted to managed a non-existant resource Puppet would just return that the service was stopped. This could be a bit confusing since if the service doesn't exist, that should be made explicit and we should do more then just returning that the service is in a 'stopped' state.
This change will cause Puppet to return an error message if a Windows/Systemd service is not found while trying to manage said service.

When managing the `ensure` state for a service, the provider queries the service status to determine if it's running or not. However, if the service doesn't exist, then it returns that the service is `stopped`. When trying to ensure a non-existent service is stopped, puppet thinks the service is "insync", so returns exit code 0. This commit updates the systemd provider's enable method to return either :running, :stopped or :absent. To differentiate between `stopped` vs `absent`, the provider first checks if the service exists. This adds `absent` as a valid value for the `ensure` property, however, it can't be set on a provider, since we don't want to remove services: puppet resource service ufw ensure=absent Error: The systemd provider can not handle attribute ensure

lib/puppet/provider/service/windows.rb

lib/puppet/type/service.rb

spec/unit/provider/service/systemd_spec.rb

spec/unit/type/service_spec.rb

joshcooper · 2023-12-15T23:30:25Z

Could you remove the lib/puppet/.DS_Store file from this PR and update the commit summary to describe the behavior change (how previously the windows and systemd providers reported the non-existent service as stopped and now it will be absent)?

spec/unit/provider/service/systemd_spec.rb

…sent Previously if a service was not present on a system and a user tried to manage that service with `puppet resource service`, and that service wasn't there an error message would appear on the screen but the puppet command would return a 0 exit code. This commit is meant to bubble up those error messages so they will be reflected on the command line properly. First pass will be to update the Windows and Systemd providers. blank

github-actions · 2023-12-20T18:15:21Z

Backport failed for 7.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 7.x
git worktree add -d .worktree/backport-9175-to-7.x origin/7.x
cd .worktree/backport-9175-to-7.x
git checkout -b backport-9175-to-7.x
ancref=$(git merge-base 9ceca21e565f0771b9bffe88a20894506c015602 4f6a2ea27ffa4451a327002bca045194d937f7aa)
git cherry-pick -x $ancref..4f6a2ea27ffa4451a327002bca045194d937f7aa

cthorn42 requested a review from a team as a code owner November 29, 2023 22:02

cthorn42 force-pushed the bug_fix/main/error_when_resource_not_found branch 4 times, most recently from 935be7a to dfc2bad Compare December 15, 2023 19:21