Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Only resolve environment dirs if versioned dirs are enabled #9131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(maint) Only resolve environment dirs if versioned dirs are enabled #9131

wants to merge 1 commit into from

Commits on Oct 23, 2023

  1. (maint) Only resolve environment dirs if versioned dirs are enabled 

    The previous implementation would not set the resolved_path variable of
an environment to the actual resolved path unless the
"report_configured_environment" was set to false. This should not matter
since the externalize_path method will check the
"report_configured_environment" setting.

The implementation should probably either always set the resolved_path
to the resolved path, or only set it if "versioned_environment_dirs" is
true. This patch sets it only if the "versioned_environment_dirs" setting
is true.
    @justinstoller
    justinstoller committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    70b4c72 View commit details
    Browse the repository at this point in the history