(PUP-11938) Handle more errors around Windows SID and ASID #9119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two new errors, ERROR_TRUSTED_DOMAIN_FAILURE and ERROR_TRUSTED_RELATIONSHIP_FAILURE. Those two errors can occur when looking up a SID and the a host fails a trust call with the AD. We can still recover and should attept to.
joshcooper
approved these changes
Oct 9, 2023
|
@cthorn42 could you submit a backport PR to 7.x? I like to use |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9119-to-7.x origin/7.x
cd .worktree/backport-9119-to-7.x
git checkout -b backport-9119-to-7.x
ancref=$(git merge-base 80226e959188bfde383a453c4ab431132c7d0f9f 9d6c9c968b12bf416e1d06d909526b8d9784a271)
git cherry-pick -x $ancref..9d6c9c968b12bf416e1d06d909526b8d9784a271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces two new errors, ERROR_TRUSTED_DOMAIN_FAILURE and ERROR_TRUSTED_RELATIONSHIP_FAILURE. Those two errors can occur when looking up a SID and the a host fails a trust call with the AD. We can still recover and should attept to.