Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing to install packages with -noarch in name #9085

Merged
merged 1 commit into from
Apr 11, 2024

Commits on Jul 10, 2023

  1. Fix failing to install packages with -noarch in name

    We're missing a `\.` at the beginning, since `.join()` only puts `|\.`
    in between items:
    
    ```
    >> ARCH_REGEX = Regexp.new(ARCH_LIST.join('|\.'))
    => /noarch|\.i386|\.i686|\.ppc|\.ppc64|\.armv3l|\.armv4b|\.armv4l|\.armv4tl|\.armv5tel|\.armv5tejl|\.armv6l|\.armv7l|\.m68kmint|\.s390|\.s390x|\.ia64|\.x86_64|\.sh3|\.sh4/
    ```
    
    Currently puppet is failing to install package with `-noarch` string in
    its name because of the invalid ARCH_REGEX:
    
    ```
    package { 'package-name-noarch':
      ensure => '1.0.0.el8'
    }
    ```
    
    ```
    Debug: Executing: '/bin/dnf -d 0 -e 1 -y install package-name--1.0.0.el8noarch'
    Error: Could not update: Execution of '/bin/dnf -d 0 -e 1 -y install package-name--1.0.0.el8noarch' returned 1: Error: Unable to find a match: package-name--1.0.0.el7noarch
    ```
    anhpt379 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ca36fc6 View commit details
    Browse the repository at this point in the history