Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-11853) Wait for request completion before closing #9084

Merged

Commits on Jul 10, 2023

  1. (PUP-11853) Wait for request completion before closing

    Before this commit, puppet would attempt to `finish` a
    connection in the block passed to an `http.request` function. This
    will not work because `finish` sets the `@socket` to nil, and the
    net/http request assumes that the `@socket` is set for the duration
    of that function. With this change, we mark some state during the
    request function that indicates the connection should be closed
    after the completion of the `http.request`.
    tvpartytonight committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7826d00 View commit details
    Browse the repository at this point in the history