(PUP-11433) Use systemd by default in CentOS/RHEL #8862
Conversation
|
Can one of the admins verify this patch? |
Since CentOS7/RHEL7, systemd is used to manage services. This change changes the default provider in CentOS/RHEL from the old redhat provider based on init, to the systemd provider, so that we no longer need to update the provider code when adding support for a new version of CentOS/RHEL. The old redhat provider is still used for CentOS/RHEL<7 which are using init to manage services.
| @@ -8,7 +8,8 @@ | |||
|
|
|||
| commands :chkconfig => "/sbin/chkconfig", :service => "/sbin/service" | |||
|
|
|||
| defaultfor :osfamily => :redhat | |||
| defaultfor :osfamily => :redhat, :operatingsystemmajrelease => (4..6).to_a | |||
| defaultfor :operatingsystem => :amazon, :operatingsystemmajrelease => ["2017"] | |||
There was a problem hiding this comment.
I think this will break some versions of Amazon Linux, as the operatingsystemmajrelease is not always 2017 (at least in some of the versions we test against):
{
"operatingsystem": "Amazon",
"operatingsystemmajrelease": "2",
"operatingsystemrelease": "2",
"os": {
"architecture": "x86_64",
"distro": {
"codename": "2017.12",
"description": "Amazon Linux release 2 (2017.12) LTS Release Candidate",
"id": "Amazon",
"release": {
"full": "2",
"major": "2"
}
},
"family": "RedHat",
"hardware": "x86_64",
"name": "Amazon",
"release": {
"full": "2",
"major": "2"
},
"selinux": {
"enabled": false
}
},
"osfamily": "RedHat",
}Also are there other platforms that report osfamily as RedHat but have a different operatingmajrelease version scheme?
There was a problem hiding this comment.
Yeah I don't think this will work. For example, on Rocky the osfamily is RedHat but the operatingsystem is Rocky so this provider would no longer be the default for that platform.
There was a problem hiding this comment.
@kajinamit did you have a chance to see my comment above? Is there another way to do this without breaking defaultfor behavior for existing platforms?
Also we recently merged changes for AL 2023 and it looks like there are conflicts that need resolving.
|
|
|
Since this PR is stale, closing this in favor of #9207 |
Since CentOS7/RHEL7, systemd is used to manage services. This change
changes the default provider in CentOS/RHEL from the old redhat
provider based on init, to the systemd provider, so that we no longer
need to update the provider code when adding support for a new version
of CentOS/RHEL.
The old redhat provider is still used for CentOS/RHEL<7 which are using
init to manage services.