-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(PUP-11853) Wait for request completion before closing
Before this commit, puppet would attempt to `finish` a connection in the block passed to an `http.request` function. This will not work because `finish` sets the `@socket` to nil, and the net/http request assumes that the `@socket` is set for the duration of that function. With this change, we mark some state during the request function that indicates the connection should be closed after the completion of the `http.request`.
- Loading branch information
1 parent
c9f17b1
commit aac5d7d
Showing
3 changed files
with
11 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters