Use File::Stat.executable? instead of File.executable?

lib/pdk/module/convert.rb

@@ -163,7 +163,7 @@ def stage_changes!(context = PDK.context)
             when :manage
               if PDK::Util::Filesystem.exist?(absolute_file_path)
                 update_manager.modify_file(absolute_file_path, file_content)
-                update_manager.make_file_executable(absolute_file_path) if file_executable && !PDK::Util::Filesystem.executable?(absolute_file_path)
+                update_manager.make_file_executable(absolute_file_path) if file_executable && !PDK::Util::Filesystem.stat(absolute_file_path).executable?
               else
                 update_manager.add_file(absolute_file_path, file_content)
                 update_manager.make_file_executable(absolute_file_path) if file_executable

lib/pdk/template/renderer/v1/renderer.rb

@@ -95,7 +95,7 @@ def render_module(options = {})
                 end
               end
 
-              dest_executable = config['manage_execute_permissions'] && PDK::Util::Filesystem.executable?(File.join(template_loc, template_file))
+              dest_executable = config['manage_execute_permissions'] && PDK::Util::Filesystem.stat(File.join(template_loc, template_file)).executable?
 
               yield dest_path, dest_content, dest_status, dest_executable
             end

spec/unit/pdk/module/convert_spec.rb

@@ -185,6 +185,8 @@ def module_path(relative_path)
       include_context 'completes a convert'
 
       before do
+        stat_double = instance_double("File::Stat", executable?: false)
+        allow(PDK::Util::Filesystem).to receive(:stat).with(module_path('/a/path/to/file')).and_return(stat_double)
         allow(PDK::Util::Filesystem).to receive(:exist?).with(module_path('/a/path/to/file')).and_return(true)
         allow(update_manager).to receive(:modify_file).with(any_args)
         allow(update_manager).to receive(:changes?).and_return(true)
@@ -227,6 +229,8 @@ def module_path(relative_path)
       include_context 'completes a convert'
 
       before do
+        stat_double = instance_double("File::Stat", executable?: false)
+        allow(PDK::Util::Filesystem).to receive(:stat).with(module_path('/a/path/to/file')).and_return(stat_double)
         allow(PDK::Util::Filesystem).to receive(:exist?).with(module_path('/a/path/to/file')).and_return(true)
         allow(update_manager).to receive(:modify_file).with(any_args)
         allow(update_manager).to receive(:changes?).and_return(true)
@@ -284,7 +288,8 @@ def module_path(relative_path)
           context 'when managing file execute bits' do
             context 'when file exists and has correct execute bits' do
               before do
-                allow(PDK::Util::Filesystem).to receive(:executable?).with(module_path('/a/path/to/file')).and_return(true)
+                stat_double = instance_double("File::Stat", executable?: true)
+                allow(PDK::Util::Filesystem).to receive(:stat).with(module_path('/a/path/to/file')).and_return(stat_double)
               end
 
               it 'does not stage the file for making executable' do
@@ -293,10 +298,6 @@ def module_path(relative_path)
             end
 
             context 'when file exists but has incorrect execute bits' do
-              before do
-                allow(PDK::Util::Filesystem).to receive(:executable?).with(module_path('/a/path/to/file')).and_return(false)
-              end
-
               it 'stages the file for making executable' do
                 expect(update_manager).to receive(:make_file_executable).with(module_path('/a/path/to/file'))
               end