Fix gce

Starting from version 4.7.1, Facter is unable to read Gce metadata like below. [2024-06-12 04:58:49.787568 ] DEBUG Facter::Util::Resolvers::Http - Trying to connect to http://metadata.google.internal/computeMetadata/v1/?recursive=true&alt=json but got: undefined method `[]' for false:FalseClass This is because get_request is getting 4 parameters. This commit set timeouts = {}, to avoid timeouts = false.
puppetlabs · Jun 13, 2024 · 3973aaa · 3973aaa
1 parent 3e47ee6
commit 3973aaa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/facter/resolvers/gce.rb b/lib/facter/resolvers/gce.rb
@@ -22,7 +22,7 @@ def read_facts(fact_name)
         end
 
         def query_for_metadata
-          gce_data = extract_to_hash(Facter::Util::Resolvers::Http.get_request(METADATA_URL, HEADERS, false))
+          gce_data = extract_to_hash(Facter::Util::Resolvers::Http.get_request(METADATA_URL, HEADERS, {}, false))
           parse_instance(gce_data)
 
           gce_data.empty? ? nil : gce_data

diff --git a/spec/facter/resolvers/gce_spec.rb b/spec/facter/resolvers/gce_spec.rb
@@ -6,7 +6,7 @@
 
   before do
     allow(Facter::Util::Resolvers::Http).to receive(:get_request)
-      .with(gce_metadata_url, gce_url_headers, false)
+      .with(gce_metadata_url, gce_url_headers, {}, false)
       .and_return(http_response_body)
   end