Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the control repository does not contain any scripts to
execute CI jobs for Puppet code deployment. This patch addresses the problem
by adding a Gitlab CI job configuration with three jobs defined across two
stages. The test stage executes first with a Syntax and a Lint job executing
in parallel. If an environment branch has been pushed, one matching
developemnt
,testing
,production
or starting with the prefixplayground
, the deploy stage is executed.The deploy stage requires a Gitlab secret environment variable, PUPPET_TOKEN.
This environment variable is the puppet access token configured with Code
Manager.
The test stage runs the following syntax checks:
The behavior of the checks are to check only files modified relative to
a base branch, defaulting to
production
. This avoids running syntaxchecks against files which have not been modified by the merge request.
The check uses
git diff --name-status
to identify changed files acrossmultiple commits in a topic branch.
The lint checks rely on bundler and the Gemfile to install numerous lint
checks.
Gem libraries are installed in a per-job location in $HOME. This is an
intentional compromise between installing into a system GEM_PATH
element, which would create library conflicts with other jobs, and the
job workspace, which would cause gem libraries to be installed from the
network on each job invocation.