Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set some default resource requests on the workspace pod #707

Merged
merged 14 commits into from
Oct 7, 2024

bugfix for advertised address

2fb59f1
Select commit
Loading
Failed to load commit list.
Merged

Set some default resource requests on the workspace pod #707

bugfix for advertised address
2fb59f1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 0s

49.57% (+0.19%) compared to 6fbcd4c

View this Pull Request on Codecov

49.57% (+0.19%) compared to 6fbcd4c

Details

Codecov Report

Attention: Patch coverage is 75.86207% with 14 lines in your changes missing coverage. Please review.

Project coverage is 49.57%. Comparing base (6fbcd4c) to head (2fb59f1).

Files with missing lines Patch % Lines
agent/cmd/serve.go 0.00% 5 Missing ⚠️
...nternal/webhook/auto/v1alpha1/workspace_webhook.go 78.94% 2 Missing and 2 partials ⚠️
operator/cmd/main.go 0.00% 3 Missing ⚠️
...r/internal/controller/auto/workspace_controller.go 93.54% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #707      +/-   ##
==========================================
+ Coverage   49.37%   49.57%   +0.19%     
==========================================
  Files          26       27       +1     
  Lines        2882     2911      +29     
==========================================
+ Hits         1423     1443      +20     
- Misses       1284     1290       +6     
- Partials      175      178       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.