Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Update eks.md #3079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update eks.md #3079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion themes/default/content/docs/clouds/aws/guides/eks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,7 +1311,7 @@ assume_role_policy = json.dumps({
"Statement": [{
"Action": "sts:AssumeRole",
"Effect": "Allow",
"Sid": None,
"Sid": "",
Copy link
Member

@cnunciato cnunciato Jun 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omidraha Since this property is apparently optional, what do you think about omitting it altogether? When I do that, it looks like the policy gets created successfully (and without a Sid) -- and when I then change the Sid to "", Pulumi detects no changes. Is there a benefit (or maybe a best practice?) to using "" as opposed to just leaving the property out?

Suggested change
"Sid": "",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the tests related to the library, an empty string has been used as a test case.

You can find an example of this usage at the following link:

https://github.com/pulumi/pulumi-aws/blob/c0dcccb3d7aef5bd661e2f74ec4c5361273d7c12/sdk/python/pulumi_aws/iam/role_policy.py#L191

May be it have been preferred to explicitly include an empty string for clarity in the policy structure.

And also, the record created in the Amazon console will be different.

  • 3079_01
  • 3079_02

"Principal": {
"Service": "ec2.amazonaws.com",
},
Expand Down