Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: debug and verbosity #1046

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: debug and verbosity #1046

wants to merge 11 commits into from

Conversation

ekbduffy
Copy link

Adding two optional inputs that are already supported by @pulumi/automation

fixes: #589

Unfortunately there's no functionality in @pulumi/automation supporting args passing.

@arthurderyckere-newday
Copy link

@ekbduffy this feature would help close issue #589
PR says there are few conflicts, can you resolve those?
@justinvp does this look OK to you?

@ekbduffy
Copy link
Author

ekbduffy commented Feb 4, 2024

@ekbduffy this feature would help close issue #589 PR says there are few conflicts, can you resolve those? @justinvp does this look OK to you?

Hey @arthurderyckere-newday , thanks for the reply! Solved the conflict. Should be good to go

Comment on lines +106 to +108
log-to-std-err:
description: 'Log to stderr instead of to files'
required: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any value in logging to files inside the action? Unless users have setup to trawl /tmp at the end of the job their just going to get lost? Wonder if this be flipped relative to automationapi and be "log-to-files" and default to logging to stderr?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekbduffy would you consider settling for log-verbose and debug options and revisit this log-to-std-err at a later stage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup the others make sense, just --log-to-stderr should probably default on if either of the others are set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a verbosity flag to the pulumi/actions
3 participants