-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: Improve docker container build, CI caching and python dependencies #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fischeti! LGTM apart for a few comments which follow :)
This reverts commit ae5aad9.
Undrafting this again after quite a lot of changes. The PR now touches a lot more than just consolidating python dependencies (see updated description). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extensive efforts @fischeti!
It looks very good, just have a few questions/comments.
6cbe8dc
to
ab897df
Compare
I pushed commit 4f89a6f to automate generation of the dependency list which determines the Verilator model build. It is based on the List Make Prerequisites Action, which parses Make's database output (from The method is still not 100% correct, e.g. if Nonetheless, the method is at least as precise as the previously proposed method, so I think we can continue with this solution, and eventually refine it in the future, when needed. |
Allows us to encode the dependency to the build-docker job
Docker container
verilator
prebuiltapt-requirements.txt
3.11
5.020
CI
ci.yml
workflow. Before, the docker container had to be manually changed and triggered on the working branch if the Docker container needed modification.pull_request
if the pull request is from an internal contributor.Python dependencies
pyproject.toml
file, replaces allrequirements.txt
files.