Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm_csrs.resp_queue_pop set also when cmdbusy_i=1 #103

Open
masgia opened this issue Dec 18, 2020 · 1 comment
Open

dm_csrs.resp_queue_pop set also when cmdbusy_i=1 #103

masgia opened this issue Dec 18, 2020 · 1 comment

Comments

@masgia
Copy link

masgia commented Dec 18, 2020

This is related to #37 : pull request #79 doesn't seem to fully solve the problem.
I see that even if cmd_busy is set, an incoming request is immediately accepted and a word is popped from the FIFO. This results in the popped world being transferred nowhere.
I am now wandering whether issuing resp_queue_pop only when cmdbusy_i=0 would solve the problem

-  assign resp_queue_pop = dmi_resp_ready_i & ~resp_queue_empty;
+  assign resp_queue_pop = dmi_resp_ready_i & ~resp_queue_empty & ~cmdbusy_i;

(tests ongoing)

@msfschaffner
Copy link
Contributor

Can you check whether this issue is solved with #138? If yes, please close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants