Make the CUT_OUP_POP_INP_GNT ID queue parameter user visible and bump common cells
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricted98
force-pushed
the
rt/id-queue-cut-oup-pop-inp-gnt
branch
from
47706fa
to
6aeedaa
Compare
niwis
approved these changes
Aug 23, 2024
SamuelRiedel
approved these changes
Aug 26, 2024
|
I defaulted it to 0 for backward compatibility since the ID queues without this parameter implicitly behave as if it was set to 0. However, I do not have a strong opinion about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
FULL_BANDWIDTH=1ID queues paired withCUT_OUP_POP_INP_GNT=0(default value) might lead to combinational loops with downstream IPs. Cutting the combinational path between input and output solves the problem.This PR extends #34 to make the
CUT_OUP_POP_INP_GNTparameter user visible and bumps thecommon_cellsdependency.Would it be better to allow more granularity, i.e. allowing for individual ID queues tuning?