Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the CCU to improve performance #5

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Rework the CCU to improve performance #5

wants to merge 39 commits into from

Commits on Apr 12, 2024

  1. Initial rework of the uarch of the CCU FSM 

    * The original FSM is now split across three modules:
decoder, memory_unit and snoop_unit.
* The top level design is now identified as ccu_ctrl
* Legacy parameter is used to simulate a blocking behavior
    @ricted98
    ricted98 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2f2cdd5 View commit details
    Browse the repository at this point in the history

  2. Define a single Legacy param and propagate it

    @ricted98
    ricted98 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    096456d View commit details
    Browse the repository at this point in the history

  3. Add AMO support and make fixes to memory unit

    @ricted98
    ricted98 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    38866ad View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Simplify Ax state encoding

    @ricted98
    ricted98 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    542f384 View commit details
    Browse the repository at this point in the history

  2. Remove commented out code

    @ricted98
    ricted98 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f7960b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Move towards non-blocking implementation 

    * Rework the memory unit to use AXI channels parallelism
* Use AXI FIFO to buffer memory transactions
* Several bug fixes
* Remove Legacy support
    @ricted98
    ricted98 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9c2f385 View commit details
    Browse the repository at this point in the history

  2. Add some relevant comments and TODOs

    @ricted98
    ricted98 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f46f1ab View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Add collision checks and fix memory CD FIFO handling 

    * Checks are currently performed by stalling requests targeted at the same set
    @ricted98
    ricted98 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8d29df1 View commit details
    Browse the repository at this point in the history

  2. Implement control on ID queues and change collision condition 

    * Stall the decoder W/R requests if the respective queue is full
* Collision now happens on equal tags
    @ricted98
    ricted98 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d4472ae View commit details
    Browse the repository at this point in the history

  3. Make collision condition parametric

    @ricted98
    ricted98 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    07ac64b View commit details
    Browse the repository at this point in the history

  4. Fix some bugs affecting memory writebacks

    @ricted98
    ricted98 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b776ad5 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Add proper arbitration on CD channels

    @ricted98
    ricted98 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    82b3093 View commit details
    Browse the repository at this point in the history

  2. Minor embellishments of the code

    @ricted98
    ricted98 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    7c39d21 View commit details
    Browse the repository at this point in the history

  3. First changes to harmonize the management of the CD channel

    @ricted98
    ricted98 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    506a41b View commit details
    Browse the repository at this point in the history

  4. Rework CD channel handling

    @ricted98
    ricted98 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    b3b0a75 View commit details
    Browse the repository at this point in the history

  5. Fix spurious assign to enum

    @ricted98
    ricted98 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    c015131 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Fix Bender.yml

    @ricted98
    ricted98 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    81ad84d View commit details
    Browse the repository at this point in the history

  2. Pass DCacheIndexWidth parameter through Cfg

    @ricted98
    ricted98 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    340828c View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Update W and B channels handling in memory unit 

    * Add one ID bit on the memory side
* Add W FIFO to decouple Ax controller and W channel
    @ricted98
    ricted98 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c332fa1 View commit details
    Browse the repository at this point in the history

  2. Save only the relevant part of the address in ID queues

    @ricted98
    ricted98 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    63d2e6f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Fix collision check lookup address

    @ricted98
    ricted98 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    54019fe View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Decouple AC reqs and CR resps

    @ricted98
    ricted98 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    15c50ad View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Rework the decoder block

    @ricted98
    ricted98 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e74eb7b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Correctly propagate AxiAddrWidth

    @ricted98
    ricted98 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6b0e273 View commit details
    Browse the repository at this point in the history

  2. Fix w_last handling in memory unit

    @ricted98
    ricted98 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0e7b3a0 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Rework the design to reduce latency 

    * Use req/gnt protocol
* Serve request in the same cycle if possible
    @ricted98
    ricted98 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9a4b617 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge pull request #2 from pulp-platform/rt/reduce-latency-rebased 

    Rework the design to reduce latency
    @ricted98
    ricted98 authored May 9, 2024
    Configuration menu
    Copy the full SHA
    404bc15 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Add performance events

    @ricted98
    ricted98 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    912cada View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Allow multiple consecutive AC requests

    @ricted98
    ricted98 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    13f79f9 View commit details
    Browse the repository at this point in the history

  2. Replace enum for AC state

    @ricted98
    ricted98 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8de8e7c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge pull request #3 from pulp-platform/rt/uarch-perf 

    Add perf events, rework the AC control
    @ricted98
    ricted98 authored May 16, 2024
    Configuration menu
    Copy the full SHA
    634da06 View commit details
    Browse the repository at this point in the history

  2. Add perf counters to memory unit

    @ricted98
    ricted98 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    74333a3 View commit details
    Browse the repository at this point in the history

  3. Remove AMO_WAIT_READ state

    @ricted98
    ricted98 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9c9c764 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Disable perf counters by default and buffer them

    @ricted98
    ricted98 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    63f3114 View commit details
    Browse the repository at this point in the history

  2. Retime AC request handling

    @ricted98
    ricted98 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    86be0f2 View commit details
    Browse the repository at this point in the history

  3. Add bypass to ccu_ctrl_decoder

    @ricted98
    ricted98 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    01cc655 View commit details
    Browse the repository at this point in the history

  4. Freeze latency configuration

    @ricted98
    ricted98 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    fbaabcf View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Fix naming convention for package parameters

    @ricted98
    ricted98 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    06180ec View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Add one cycle latency in id_queues to cut timing loops.

    @ricted98
    Yvan Tortorella authored and ricted98 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    409b1bf View commit details
    Browse the repository at this point in the history