Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-france: Use stable urls #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

generate-france: Use stable urls #481

wants to merge 1 commit into from

Conversation

jbruechert
Copy link
Collaborator

No description provided.

@kalon33
Copy link
Contributor

kalon33 commented Sep 2, 2024

It seems to be working, only 4 errors in the test run (missing agency.txt, all from the same feed producer)

@jbruechert
Copy link
Collaborator Author

Will add these to the exclusion list then in the evening

@jbruechert
Copy link
Collaborator Author

jbruechert commented Sep 2, 2024

Unfortunately these feeds are fairly important, but return something like

donnees;format;download
Horaires des trains Transilien NeTEx;NeTEx;https://eu.ftp.opendatasoft.com/sncf/gtfs/transilien-netexfr.zip
Horaires des trains Transilien GTFS;GTFS;https://eu.ftp.opendatasoft.com/sncf/gtfs/transilien-gtfs.zip

Maybe the logic for picking the right resource needs some improvement.

EDIT we are already picking the right resource, but "url" and "original_url" don't return the same.

@kalon33
Copy link
Contributor

kalon33 commented Sep 3, 2024

Unfortunately these feeds are fairly important, but return something like

donnees;format;download
Horaires des trains Transilien NeTEx;NeTEx;https://eu.ftp.opendatasoft.com/sncf/gtfs/transilien-netexfr.zip
Horaires des trains Transilien GTFS;GTFS;https://eu.ftp.opendatasoft.com/sncf/gtfs/transilien-gtfs.zip

Maybe the logic for picking the right resource needs some improvement.

EDIT we are already picking the right resource, but "url" and "original_url" don't return the same.

Yep indeed, SNCF feeds are relevant for most trains in France...

I still don't see some data in transitous (Cap Cotentin related data notably) do you know why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants