Various upgrades #1716
Merged
Various upgrades #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
GBPTM
|
||||||||||||||||||||||||||||
| Project |
GBPTM
|
| Branch Review |
refs/pull/1716/merge
|
| Run status |
|
| Run duration | 03m 36s |
| Commit |
|
| Committer | Oliver Barnwell |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
63
|
| View all changes introduced in this branch ↗︎ | |
ob6160
force-pushed
the
ob/dep-update
branch
from
2417ea0
to
f39b8e8
Compare
ob6160
requested review from
mxdvl,
marxian,
Hoolean,
charlesstrange2 and
rosejbon
mxdvl
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
I'd recommend pinning dependencies in package.json. Also curious about the use of devDependencies — what do they represent?
yes I agree, has been on my to-do list for a while, I'll raise a followup when I have the time
these have become a bit of a mess over time, some deps for prod are in the dev deps — another followup will be to sort through these and work out which are truly dev deps both followups open to others contributing, let me know if you fancy picking something up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?