Add optional email field for feedback, record feedback in db #1695

ob6160 · 2024-07-27T16:14:01Z

What does this change?

This improves the feedback form, adding an optional email field so we can get in touch with individuals who wish to be contacted back
- This has been covered by changes to our privacy policy in: Update privacy.page.tsx #1715
We also record the route so we know which page the user sent the feedback from
Some small improvements to accessibility and width on mobile

vercel · 2024-07-27T16:14:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
toiletmap	✅ Ready (Inspect)	Visit Preview	Oct 1, 2024 9:40pm

github-actions · 2024-07-31T10:41:36Z

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`197.28 KB` (🟡 +153 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`200 KB`)
`/`	`12.19 KB`	209.48 KB	104.74% (+/- <0.01%)
`/explorer/loos/[id]`	`16.4 KB`	213.69 KB	106.84% (🟡 +0.01%)
`/explorer/search`	`16.83 KB`	214.11 KB	107.05% (+/- <0.01%)
`/loos/[id]`	`20.32 KB`	217.6 KB	108.80% (+/- <0.01%)
`/loos/[id]/edit`	`45.79 KB`	243.07 KB	121.54% (🟢 -0.01%)
`/loos/[id]/remove`	`16.11 KB`	213.39 KB	106.70% (+/- <0.01%)
`/loos/add`	`45.27 KB`	242.55 KB	121.28% (🟢 -0.02%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

cypress · 2024-07-31T10:47:44Z

GBPTM Run #1330

Run Properties: Passed #1330 • e9c22e2d77 ℹ️: Merge cdf437d53c08419bee8c81ef9a2e447284aa28a5 into 5152c959bb2fa58757ceed0d0f71...

Project	`GBPTM`
Branch Review	`refs/pull/1695/merge`
Run status	`Passed #1330`
Run duration	`03m 10s`
Commit	`e9c22e2d77 ℹ️: Merge cdf437d53c08419bee8c81ef9a2e447284aa28a5 into 5152c959bb2fa58757ceed0d0f71...`
Committer	`Oliver Barnwell`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`63`
View all changes introduced in this branch ↗︎

github-actions · 2024-08-23T18:06:57Z

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`197.28 KB` (🟡 +277 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`200 KB`)
`/explorer/loos/[id]`	`16.4 KB`	213.67 KB	106.84% (🟢 -0.01%)
`/explorer/search`	`16.82 KB`	214.1 KB	107.05% (+/- <0.01%)
`/loos/[id]/edit`	`45.79 KB`	243.07 KB	121.53% (🟢 -0.01%)
`/loos/add`	`45.27 KB`	242.55 KB	121.27% (🟢 -0.01%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

github-actions · 2024-09-01T16:10:19Z

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`197.32 KB` (🟡 +323 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`200 KB`)
`/explorer/loos/[id]`	`16.4 KB`	213.72 KB	106.86% (+/- <0.01%)
`/explorer/search`	`16.82 KB`	214.14 KB	107.07% (+/- <0.01%)
`/loos/[id]`	`20.32 KB`	217.64 KB	108.82% (+/- <0.01%)
`/loos/[id]/edit`	`45.76 KB`	243.08 KB	121.54% (🟢 -0.02%)
`/loos/[id]/remove`	`16.04 KB`	213.36 KB	106.68% (🟢 -0.03%)
`/loos/add`	`45.24 KB`	242.56 KB	121.28% (🟢 -0.03%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

mxdvl

db: the SQL

src/pages/api/feedback/index.page.ts

Hoolean

Nice 💪 Added a few comments on validation and column types (and some bits I am just curious about); nothing blocking though, otherwise looks good to me

schema.prisma

Hoolean · 2024-09-23T20:59:41Z

schema.prisma

+  id            Int       @id @default(autoincrement())
+  email         String?   @db.VarChar(255)
+  feedback_text String
+  route         String


any other properties we should stick a limit on too? 🔎

I've limited feedback_text to 5000 chars and route to 255, both seemed reasonable. If someone has more than 5000>chars to write they better write us an email

src/pages/api/feedback/index.page.ts

Hoolean · 2024-09-23T21:04:04Z

src/pages/api/feedback/index.page.ts

+    // We'd like to record the full feedback entry in our database for future reference.
+    await prisma.feedback.create({
+      data: {
+        email: email ?? 'No email provided',


can we make this column nullable instead?

nice catch, this is nullable by default so I didn't really need to have this text fallback. if email is undefined/null this field will be null too. will remove the fallback

supabase/migrations/20240823182342_feedback_table.sql

Hoolean · 2024-09-23T21:17:53Z

Whoopsy, I've double-reviewed you - definitely not meant to replace yours Max, just had the page open too long before hitting go 😄

ob6160 · 2024-09-23T21:24:27Z

Whoopsy, I've double-reviewed you - definitely not meant to replace yours Max, just had the page open too long before hitting go 😄

thanks for the extra comments, all good points - i'll get back soon 🚗

…e a record of it in our database add migration for feedback table

…sisted to db successfully

ob6160 · 2024-10-01T21:47:04Z

@Hoolean I've had a look and made some changes based on your feedback :)

Hoolean

All feedback addressed

vercel bot deployed to Preview July 27, 2024 16:14 View deployment

vercel bot deployed to Preview July 31, 2024 10:40 View deployment

ob6160 force-pushed the ob/feedback-improvements branch from ef8df4a to 974464e Compare August 23, 2024 18:04

vercel bot deployed to Preview August 23, 2024 18:06 View deployment

ob6160 changed the base branch from main to ob/psql-overhaul August 23, 2024 18:08

vercel bot deployed to Preview September 1, 2024 16:09 View deployment

ob6160 changed the title ~~Add optional name and email fields for feedback~~ Add optional email field for feedback, record feedback in db Sep 1, 2024

ob6160 force-pushed the ob/psql-overhaul branch 2 times, most recently from a79616c to 5abf505 Compare September 21, 2024 14:28

Base automatically changed from ob/psql-overhaul to main September 21, 2024 21:58

ob6160 force-pushed the ob/feedback-improvements branch from 6f3c7a5 to adbc0f2 Compare September 23, 2024 18:26

ob6160 requested review from marxian and charlesstrange2 September 23, 2024 18:27

vercel bot deployed to Preview September 23, 2024 18:29 View deployment

ob6160 requested review from stphnnnn, mxdvl, Hoolean and rosejbon September 23, 2024 19:08

mxdvl approved these changes Sep 23, 2024

View reviewed changes

src/pages/api/feedback/index.page.ts Outdated Show resolved Hide resolved

Hoolean reviewed Sep 23, 2024

View reviewed changes

ob6160 force-pushed the ob/feedback-improvements branch from adbc0f2 to c38bbfc Compare September 23, 2024 21:15

vercel bot deployed to Preview September 23, 2024 21:17 View deployment

add optional name and email fields for feedback

d077d66

ob6160 added 3 commits October 1, 2024 22:34

improve feedback system so people can provide their email and we stor…

cac4eb6

…e a record of it in our database add migration for feedback table

set limit on feedback_text and route fields, udpate aria tag

3bb8df9

catch failure on slack webhook submission and still return 200 if per…

919ee6f

…sisted to db successfully

ob6160 force-pushed the ob/feedback-improvements branch from c38bbfc to 919ee6f Compare October 1, 2024 21:34

vercel bot deployed to Preview October 1, 2024 21:37 View deployment

add empty input check before attempting to submit it

cdf437d

vercel bot deployed to Preview October 1, 2024 21:40 View deployment

ob6160 requested a review from Hoolean October 1, 2024 21:46

Hoolean approved these changes Oct 3, 2024

View reviewed changes

ob6160 merged commit 4a92dcd into main Oct 3, 2024
14 checks passed

ob6160 deleted the ob/feedback-improvements branch October 3, 2024 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add optional email field for feedback, record feedback in db #1695

Add optional email field for feedback, record feedback in db #1695

ob6160 commented Jul 27, 2024 •

edited

Loading

vercel bot commented Jul 27, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024

cypress bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024

github-actions bot commented Sep 1, 2024

mxdvl left a comment

Hoolean left a comment

Hoolean Sep 23, 2024

ob6160 Oct 1, 2024

Hoolean Sep 23, 2024

ob6160 Oct 1, 2024 •

edited

Loading

Hoolean commented Sep 23, 2024

ob6160 commented Sep 23, 2024

ob6160 commented Oct 1, 2024

Hoolean left a comment

Add optional email field for feedback, record feedback in db #1695

Add optional email field for feedback, record feedback in db #1695

Conversation

ob6160 commented Jul 27, 2024 • edited Loading

What does this change?

vercel bot commented Jul 27, 2024 • edited Loading

github-actions bot commented Jul 31, 2024

📦 Next.js Bundle Analysis for toiletmap

⚠️ Global Bundle Size Increased

Seven Pages Changed Size

cypress bot commented Jul 31, 2024 • edited Loading

GBPTM Run #1330

github-actions bot commented Aug 23, 2024

📦 Next.js Bundle Analysis for toiletmap

⚠️ Global Bundle Size Increased

Four Pages Changed Size

github-actions bot commented Sep 1, 2024

📦 Next.js Bundle Analysis for toiletmap

⚠️ Global Bundle Size Increased

Six Pages Changed Size

mxdvl left a comment

Choose a reason for hiding this comment

Hoolean left a comment

Choose a reason for hiding this comment

Hoolean Sep 23, 2024

Choose a reason for hiding this comment

ob6160 Oct 1, 2024

Choose a reason for hiding this comment

Hoolean Sep 23, 2024

Choose a reason for hiding this comment

ob6160 Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

Hoolean commented Sep 23, 2024

ob6160 commented Sep 23, 2024

ob6160 commented Oct 1, 2024

Hoolean left a comment

Choose a reason for hiding this comment

ob6160 commented Jul 27, 2024 •

edited

Loading

vercel bot commented Jul 27, 2024 •

edited

Loading

cypress bot commented Jul 31, 2024 •

edited

Loading

ob6160 Oct 1, 2024 •

edited

Loading