Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace unmaintained action-rs #166

Merged
merged 4 commits into from
Dec 5, 2023
Merged

ci: replace unmaintained action-rs #166

merged 4 commits into from
Dec 5, 2023

Conversation

mpizenberg
Copy link
Member

@mpizenberg mpizenberg commented Dec 1, 2023

This fixes #164

actions-rs organization became unmaintained we should move our CI to no longer use it.

In this PR, I opted for using dtolnay's action. It is straightforward to use.

I've removed caches for the test and check_documentation jobs which had caching. The docs job is now faster, 15s against 20s. And the test job is slightly slower (50s against 43s roughly). Let's avoid the added complexity of caching as long as we can keep CI under a minute or so.

@mpizenberg mpizenberg marked this pull request as ready for review December 1, 2023 20:35
Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@Eh2406 Eh2406 added this pull request to the merge queue Dec 5, 2023
Merged via the queue into dev with commit 75c4a35 Dec 5, 2023
5 checks passed
@Eh2406 Eh2406 deleted the mp/no-action-rs branch December 5, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants