Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More verbose debug assert #137

Merged
merged 1 commit into from
Oct 27, 2023
Merged

More verbose debug assert #137

merged 1 commit into from
Oct 27, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 25, 2023

Accidentally caused this error, added a better debug message

@Eh2406
Copy link
Member

Eh2406 commented Oct 25, 2023

Thank you! This looks good. When CI is green I will be happy to merge.

Can you elaborate on how you hit this error? I'm surprised a higher level / user facing check didn't catch the bug.

@Eh2406
Copy link
Member

Eh2406 commented Oct 26, 2023

(The commit message needs to follow "conventional commit" before I can merge.)

@mpizenberg
Copy link
Member

(The commit message needs to follow "conventional commit" before I can merge.)

Nah, it's fine you rename the commit anyway when merging so you can conventionalize it @Eh2406

@Eh2406
Copy link
Member

Eh2406 commented Oct 26, 2023

@mpizenberg how can I check that the new message will make CI happy. I have messed up before and ended merging with a bad name and had red CI on dev, witch required doing a force push to fix, witch required turning off the branch protection. Witch is a mess I don't want to repeat.

@mpizenberg
Copy link
Member

Ahah, ok makes sense ^^

@konstin
Copy link
Member Author

konstin commented Oct 27, 2023

commitlint passes locally, though i don't know if it matches the CI one.

Can you elaborate on how you hit this error? I'm surprised a higher level / user facing check didn't catch the bug.

iirc i was midway into refactoring that made more versions available (those with only a source distribution and lacking a wheel) in on place but not in another.

Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Eh2406 Eh2406 merged commit 8951e37 into pubgrub-rs:dev Oct 27, 2023
5 checks passed
@konstin konstin deleted the dev branch October 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants