Extend error type to Send + Sync
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eh2406
approved these changes
Oct 18, 2023
|
I trust you on this one. |
Eh2406
pushed a commit
that referenced
this pull request
Oct 19, 2023
zanieb
pushed a commit
to astral-sh/pubgrub
that referenced
this pull request
Nov 8, 2023
This was referenced Nov 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Though we may want to adopt a fully generic error type eventually, this at least makes the error type compatible with
anyhow(and makes it async-friendly, which is both good and bad, since it requires that user errors are thread safe regardless of whether it's important for them to be).See: #116