Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented UPGRADE high lvl Connect command #814

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

Majkluss
Copy link
Contributor

No description provided.

Copy link
Contributor

@TojikCZ TojikCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subprocess run má atribut check, kterej myslím dělá to samý jako check_call. Použil bych ten

@Majkluss
Copy link
Contributor Author

subprocess run má atribut check, kterej myslím dělá to samý jako check_call. Použil bych ten

Používám tam CalledProcessError pro celý tenhle blok, takže mi check_call v případě problému vrátí tuhle výjimku a můžu jí odchytit, takže proto tam mám check_call, ale jinak je to podobné, ano.

@Majkluss Majkluss requested review from TojikCZ and ondratu July 24, 2023 07:30
@Majkluss Majkluss merged commit c58387d into master Jul 24, 2023
2 checks passed
@Majkluss Majkluss deleted the connect-2388_upgrade_link branch July 24, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants