Add RawProgressCode & ProgressCode::_cnt #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
CZDanol
force-pushed
the
progress-code-cnt
branch
from
3c6920a
to
c9e4cd9
Compare
DRracer
reviewed
Jan 3, 2024
| @@ -50,5 +53,7 @@ enum class ProgressCode : uint_fast8_t { | |||
| HWTestDisplay, // P35 | |||
| ErrHwTestFailed, // P36 | |||
|
|
|||
| _cnt, | |||
There was a problem hiding this comment.
🙏 add a comment describing the fact, that _cnt shall be kept pre-last just before the Empty item
CZDanol
force-pushed
the
progress-code-cnt
branch
from
c9e4cd9
to
3975548
Compare
DRracer
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProgressCode can be extended by printer-specific codes, so we're introducing here some code that makes that easier.