Add missing titles #156
Merged
Add missing titles #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomcus
force-pushed
the
add-missing-titles
branch
from
6dcbfc8
to
b5adec7
Compare
Tomcus
force-pushed
the
add-missing-titles
branch
from
b5adec7
to
a504675
Compare
CZDanol
approved these changes
Aug 9, 2024
| @@ -0,0 +1,43 @@ | |||
| import unittest | |||
Tomcus
force-pushed
the
add-missing-titles
branch
from
a504675
to
c7e4712
Compare
The bootloader only shows "Error #XXXX" as a title. But other bootloader errors were assigned a title, so I took "artistic liberties" to assign something to them BFW-5773
Technically the printer doesn't show any title when showing warnings (the title that is shown is the title of the screen that was rendered before the warning was shown). Similar to error `XX806` we can set every warning title to "Warning". BFW-5773
These errors are shown during crash recovery and the screen sets common title for all of them. BFW-5773
The only remaining dialog was Quick Pause dialog. Again since it is a dialog it doesn't have any title in the code, but we can assign its name after the feature, similar to warnings. BFW-5773
This is a generic error that happens in Load/Unload with MMU. There is large number of errors that can happen during the MMU Loading/Unloading so we use a generic title here. BFW-5773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing (replaced empty) titles. Check the commits for more info.
Also I have added a simple test that verifies the provided data (I know that most of the errors would be caught when generating the c++ code in our repo, but we can now check the values too (at least their length)).
BFW-5773