Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert gRPC calls #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Assert gRPC calls #17

wants to merge 1 commit into from

Conversation

alexsnaps
Copy link
Contributor

This is one of the two additions we've done to the framework: support asserting on gRPC calls
Follow up would be reading properties: Kuadrant#1

@alexsnaps
Copy link
Contributor Author

Ugh 🤦 I should test the stuff I cherry-pick from another branch... brb

@alexsnaps
assert grpc calls
1b82309 
Signed-off-by: Alex Snaps <[email protected]>
PiotrSikora
PiotrSikora reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance that you could add a simple gRPC example to Proxy-Wasm Rust SDK that would exercise the new code paths?

Yes, we want to test the test framework :)

@alexsnaps
Copy link
Contributor Author

alexsnaps commented Aug 11, 2023 •
edited
Loading

Yeah. I'll try to find something that avoids pulling things other than basic types tho, to avoid needing protoc - wdyt?

@PiotrSikora
Copy link
Member

Definitely! The simpler the better.

@PiotrSikora
Copy link
Member

PiotrSikora commented Jul 13, 2024 •
edited
Loading

FYI, I've added basic gRPC example in proxy-wasm/proxy-wasm-rust-sdk#248.

@PiotrSikora
Copy link
Member

FYI, I've added basic gRPC example in proxy-wasm/proxy-wasm-rust-sdk#248.

Merged in #23. Could you add coverage for them in this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsnaps @PiotrSikora