Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): add new fixer rds_instance_no_public_access_fixer #5794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danibarranqueroo
Copy link
Member

Context

Developed a new fixer that modifies the network configuration of RDS instances to ensure they are not publicly accessible, there are different ways to solve this such as restricting access to trusted IP addresses, VPCs, or specific security groups or changing the PubliclyAccessible parameter of the instance to false. As most of times the check will fail due to the last option, this is the way I'll fix it . This will enhance the security of database resources by preventing exposure to the public internet.

Description

Added new fixer rds_instance_no_public_access_fixer with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (3608aa3) to head (4ab2753).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5794      +/-   ##
==========================================
- Coverage   89.91%   89.87%   -0.04%     
==========================================
  Files        1128     1133       +5     
  Lines       35180    35285     +105     
==========================================
+ Hits        31631    31714      +83     
- Misses       3549     3571      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant