Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arn): refactor arn for unknown resources #5712

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedrooot
Copy link
Member

Description

This pull request includes changes to various AWS service checks to ensure that the resource_arn is correctly set when certain conditions are met. Additionally, corresponding test cases have been updated to reflect these changes.

Changes to AWS service checks:

Updates to test cases:

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners November 11, 2024 10:18
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (bc3cd43) to head (df9a396).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...ny_regions/organizations_scp_check_deny_regions.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5712      +/-   ##
==========================================
+ Coverage   89.89%   89.91%   +0.01%     
==========================================
  Files        1122     1124       +2     
  Lines       34782    34831      +49     
==========================================
+ Hits        31269    31317      +48     
- Misses       3513     3514       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, generate the Unknown ARN in each service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants