Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jira): add jira integration #5629

Merged
merged 19 commits into from
Nov 11, 2024

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Nov 4, 2024

Description

This pull request introduces a the new Jira integration and a new set of exception classes for handling various Jira-related errors. These changes aim to provide more specific error handling and clearer messages for different Jira operations.
Screenshot 2024-11-08 at 13 04 16

New exception classes for Jira errors:

  • Added a base exception class JiraBaseException that inherits from ProwlerException and includes a dictionary of Jira-specific error codes and their corresponding messages and remediations.
  • Defined multiple specific exception classes for different Jira error scenarios, such as JiraNoProjectsError, JiraAuthenticationError, JiraTestConnectionError, and others, each inheriting from JiraBaseException.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 47 lines in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (ce1e9de) to head (a207aab).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
prowler/lib/outputs/jira/jira.py 84.41% 41 Missing ⚠️
prowler/lib/outputs/jira/exceptions/exceptions.py 90.90% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5629      +/-   ##
==========================================
- Coverage   89.88%   89.88%   -0.01%     
==========================================
  Files        1120     1126       +6     
  Lines       34760    35144     +384     
==========================================
+ Hits        31245    31588     +343     
- Misses       3515     3556      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedrooot pedrooot marked this pull request as ready for review November 7, 2024 17:41
@pedrooot pedrooot requested review from a team as code owners November 7, 2024 17:41
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fantastic!! Thank you for all the effort you put on this one, please review my comments when you get a chance.

prowler/lib/outputs/jira/exceptions/exceptions.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/exceptions/exceptions.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/exceptions/exceptions.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/exceptions/exceptions.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/exceptions/exceptions.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
@jfagoagas jfagoagas self-requested a review November 8, 2024 10:55
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
prowler/lib/outputs/jira/jira.py Outdated Show resolved Hide resolved
jfagoagas
jfagoagas previously approved these changes Nov 8, 2024
jfagoagas
jfagoagas previously approved these changes Nov 8, 2024
@jfagoagas jfagoagas self-requested a review November 11, 2024 12:15
@jfagoagas jfagoagas merged commit f1f68da into master Nov 11, 2024
9 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5138-development-of-jira-integration-class branch November 11, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants