Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dms): add new check dms_replication_task_source_logging_enabled #5627

Conversation

danibarranqueroo
Copy link
Member

Context

This new check verifies whether logging is enabled with a minimum severity level of severify for AWS Database Migration Service (DMS) replication tasks related to the source database. This includes tasks such as SOURCE_CAPTURE and SOURCE_UNLOAD. The control fails if logging is not enabled or if the minimum severity level for those tasks is not one of the following for the preceding replication tasks: LOGGER_SEVERITY_DEFAULT, LOGGER_SEVERITY_DEBUG, or LOGGER_SEVERITY_DETAILED_DEBUG.

Logging is vital for monitoring, troubleshooting, auditing, and ensuring successful data replication between databases. The default severity level ensures that informational messages, warnings, and error messages are recorded.

Description

Added new check dms_replication_task_source_logging_enabled with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners November 4, 2024 16:41
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (a2dba30) to head (a037d9b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5627      +/-   ##
==========================================
+ Coverage   89.84%   89.86%   +0.01%     
==========================================
  Files        1118     1119       +1     
  Lines       34664    34724      +60     
==========================================
+ Hits        31144    31203      +59     
- Misses       3520     3521       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit d5873c0 into master Nov 6, 2024
11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4468-ensure-dms-replication-tasks-for-the-source-database-have-logging-enabled branch November 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants