-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dms): add new check dms_replication_task_source_logging_enabled
#5627
Merged
MrCloudSec
merged 12 commits into
master
from
PRWLR-4468-ensure-dms-replication-tasks-for-the-source-database-have-logging-enabled
Nov 6, 2024
Merged
feat(dms): add new check dms_replication_task_source_logging_enabled
#5627
MrCloudSec
merged 12 commits into
master
from
PRWLR-4468-ensure-dms-replication-tasks-for-the-source-database-have-logging-enabled
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Issues/PRs related with the AWS provider
label
Nov 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5627 +/- ##
==========================================
+ Coverage 89.84% 89.86% +0.01%
==========================================
Files 1118 1119 +1
Lines 34664 34724 +60
==========================================
+ Hits 31144 31203 +59
- Misses 3520 3521 +1 ☔ View full report in Codecov by Sentry. |
…or-the-source-database-have-logging-enabled'
…r-the-source-database-have-logging-enabled
MrCloudSec
approved these changes
Nov 6, 2024
MrCloudSec
deleted the
PRWLR-4468-ensure-dms-replication-tasks-for-the-source-database-have-logging-enabled
branch
November 6, 2024 20:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This new check verifies whether logging is enabled with a minimum severity level of severify for AWS Database Migration Service (DMS) replication tasks related to the source database. This includes tasks such as SOURCE_CAPTURE and SOURCE_UNLOAD. The control fails if logging is not enabled or if the minimum severity level for those tasks is not one of the following for the preceding replication tasks: LOGGER_SEVERITY_DEFAULT, LOGGER_SEVERITY_DEBUG, or LOGGER_SEVERITY_DETAILED_DEBUG.
Logging is vital for monitoring, troubleshooting, auditing, and ensuring successful data replication between databases. The default severity level ensures that informational messages, warnings, and error messages are recorded.
Description
Added new check
dms_replication_task_source_logging_enabled
with its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.