Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(servicecatalog): Add new service servicecatalog #5618

Conversation

MarioRgzLpz
Copy link
Member

Context

In order to cover more checks, we need to create a new AWS service for ServiceCatalog. This new service will allow for the implementation of additional checks and ensure enhanced governance and compliance within Service Catalog portfolios.

Description

Add new service ServiceCatalog with two models Portfolio and PortfolioShare and 3 methods to describe portfolios. Added unit tests for everything.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MarioRgzLpz MarioRgzLpz requested review from a team as code owners November 4, 2024 10:18
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.84%. Comparing base (e4400ec) to head (68592be).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
.../services/servicecatalog/servicecatalog_service.py 82.14% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5618      +/-   ##
==========================================
+ Coverage   89.70%   89.84%   +0.13%     
==========================================
  Files        1104     1117      +13     
  Lines       34262    34634     +372     
==========================================
+ Hits        30734    31116     +382     
+ Misses       3528     3518      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit a2dba30 into master Nov 6, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4271-add-new-service-catalog-check-for-portfolio-sharing-within-aws-organization branch November 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants