Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iam): Add note for EKS not repairable case #4759

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Aug 16, 2024

Context

Fix #4745

Description

Update iam_role_cross_service_confused_deputy_prevention metadata.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners August 16, 2024 07:59
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (bcc8d5f) to head (d591ee1).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
+ Coverage   89.10%   89.13%   +0.03%     
==========================================
  Files         913      920       +7     
  Lines       27913    28125     +212     
==========================================
+ Hits        24871    25070     +199     
- Misses       3042     3055      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should improve the logic of the check to avoid false negatives, like in #4714 too.

@sergargar sergargar added the no-merge Please, DO NOT MERGE this PR. label Aug 20, 2024
@puchy22 puchy22 marked this pull request as draft September 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-merge Please, DO NOT MERGE this PR. provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confused Deputy Attack finding for AWS EKS service
2 participants