fix(aws): solve invalid ECR Registry ARN (#5622)

prowler-cloud · Nov 4, 2024 · 84d4e4a · 84d4e4a
1 parent 5fbf8dd
commit 84d4e4a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/prowler/providers/aws/services/ecr/ecr_service.py b/prowler/providers/aws/services/ecr/ecr_service.py
@@ -58,7 +58,7 @@ def _describe_registries_and_repositories(self, regional_client):
             # The default ECR registry is assumed
             self.registries[regional_client.region] = Registry(
                 id=self.registry_id,
-                arn=f"arn:{self.audited_partition}:ecr:{regional_client.region}:registry/{self.registry_id}",
+                arn=f"arn:{self.audited_partition}:ecr:{regional_client.region}:{self.audited_account}:registry/{self.registry_id}",
                 region=regional_client.region,
                 repositories=regional_registry_repositories,
             )

diff --git a/tests/providers/aws/services/ecr/ecr_service_test.py b/tests/providers/aws/services/ecr/ecr_service_test.py
@@ -203,6 +203,10 @@ def test_describe_registries_and_repositories(self):
 
         assert len(ecr.registries) == 1
         assert ecr.registries[AWS_REGION_EU_WEST_1].id == AWS_ACCOUNT_NUMBER
+        assert (
+            ecr.registries[AWS_REGION_EU_WEST_1].arn
+            == f"arn:aws:ecr:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:registry/{AWS_ACCOUNT_NUMBER}"
+        )
         assert ecr.registries[AWS_REGION_EU_WEST_1].region == AWS_REGION_EU_WEST_1
         assert len(ecr.registries[AWS_REGION_EU_WEST_1].repositories) == 1