Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running CFU-Playground natively with notebook in rad-lab env #11

Open
wants to merge 95 commits into
base: tuning
Choose a base branch
from

Conversation

ShvetankPrakash
Copy link

Updated environment with CFU-Playground packages, repo, and other needed toolchains. Added CFU-Playground notebook after converting to markdown.

proppy and others added 30 commits March 31, 2022 21:19
- replace container base image with deeplearning image
- provision eda tooling using conda
- add daisy-based workflow to build compute engine image
- add compute binding for cloudbuild service account
- reduce image build time to ~15min
Setting the account config by running gcloud config set account ACCOUNT command and making sure that same user account is set in account config with which RAD Lab launcher has been authenticated
This reverts commit c8ba8a3.
- replace container base image with deeplearning image
- provision eda tooling using conda
- add daisy-based workflow to build compute engine image
- add compute binding for cloudbuild service account
- reduce image build time to ~15min
@github-actions
Copy link

Apache 2.0 License check successful!

@@ -60,3 +61,12 @@ cp ${PROVISION_DIR}/papermill-launcher /usr/local/bin/
chmod +x /usr/local/bin/papermill-launcher

echo "DaisySuccess: done"

echo "Cloning CFU-Playground repository"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this need to happen before DaisySuccess: done

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay i can fix this

@@ -13,14 +13,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
channels:
- defaults
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why you needed this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that different from main?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im actually not sure it was just in the cfu playground env so i ported it over

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proppy will double check

@@ -34,10 +34,55 @@ dependencies:
- pandas
- pymeep=*=mpi_mpich_*
- jupyterlab
- python
- litex-hub::gcc-riscv32-elf-newlib
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shoudn't need to prefix them by litex-hub if it's the first one in the list of channels.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to prefix those, then we should do it consistently for all packages.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove these prefixes

- intervaltree
- json-c
- libevent
- python=3.7
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we limited on 3.7?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to remove 3.7 and see if still works

- Pillow
- intervaltree
- junit-xml
- numpy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason we don't install the conda version of those?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will move these to above pip

- python-constraint
- fasm
- https://github.com/chipsalliance/f4pga/archive/8c411eb74e4bb23d1ec243a1515b9bfb48e2cd83.zip#subdirectory=f4pga
- git+https://github.com/f4pga/prjxray.git@ae546d6b7648bf4df9cf63f0b25b2028b5623c43#egg=prjxray
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't those already install with - litex-hub::prjxray-db in the conda section?


```python
# Change directory to design space exploration project in CFU-Playground
%cd /CFU-Playground/proj/dse_template
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to %cd so that you can import dse_framework or are there other part of the cfu flow dependent on stuff being executed from this location?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both are correct: to import as well as execute other parts of the cfu

@ShvetankPrakash
Copy link
Author

FYI @tcal-x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants