Add /proc/modules support

[Dentrax]

Signed-off-by: Furkan [email protected]

I have some use-cases for this implementation:

• want to parse my /proc/interrupts file using procfs package (with go:linkname)
• move module parsing logic from node-problem-detector to here

All tests passes.

Fixes #478

[discordianfish]

Is it expected that the parsing might fail? If not, we should just abort here and return the error then silentely ignoring it.

[Dentrax]

Is it expected that the parsing might fail?

Yes, I think it's possible. Checking the error could also prevent from spec changes. (too low possibility, but still would be better than not checking instead.)

[discordianfish]

yeah but I don't like that we silentely ignore the error here. Why not return an error if err != nil?

[Dentrax]

Why not return an error if err != nil?

That's because I noticed this err == nil pattern in some places. For example, arp:

procfs/arp.go

Line 98 in 0c4b3aa

if mac, err := net.ParseMAC(columns[3]); err == nil {

zoneinfo:

procfs/zoneinfo.go

Line 186 in 0c4b3aa

if err == nil {

I agree with you, returning an error would better. I can return an error if you want. Wdyt?

[discordianfish]

@SuperQ wdyt? But yeah I think returning an error would be better

[SuperQ]

Yes, returning the error would be better.

[discordianfish]

@Dentrax Can you change this so we can merge it?

[SuperQ]

Yes, returning the error would be better.

[rexagod]

@Dentrax Just a nit, but can you add Fixes #478 to the description so that the original issue is closed when this gets in?