Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance_schema.status_by_host gauge #465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romuald
Copy link

@romuald romuald commented Apr 23, 2020

This commit aims at adding a gauge measuring the contents of the
performance_schema.status_by_host table

Gauge name is mysql_perf_schema_status_by_host,
with labels host and variable_name

This commit aims at adding a gauge measuring the contents of the
`performance_schema.status_by_host` table

Gauge name is `mysql_perf_schema_status_by_host`,
with labels `host` and `variable_name`

Signed-off-by: Romuald Brunet <[email protected]>
@romuald
Copy link
Author

romuald commented Apr 23, 2020

Please note that this is my first PR on some Go code in general. I've simply copied one of the other modules, trying to rename things properly.
I'm also unaware of some possible naming conventions used in the project

Tested locally with a Percona server 5.7

@romuald
Copy link
Author

romuald commented Apr 24, 2020

poke @SuperQ because I forgot to read the CONTRIBUTING before opening the PR

@SuperQ
Copy link
Member

SuperQ commented Apr 24, 2020

Can you describe more about what this table is useful for in a monitoring context?

@romuald
Copy link
Author

romuald commented Apr 24, 2020

@SuperQ in our case, we had a some SQL clients doing "bad" queries and increasing the read_rnd_next handlers (mysql_global_status_handlers_total{handler="read_rnd_next"})

Monitoring this table helped us to narrow the host / process behaving poorly

Did you mean to add this context in the commit or files too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants