Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize BuildFQName function #1665

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Optimize BuildFQName function #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions prometheus/metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,23 @@ func BuildFQName(namespace, subsystem, name string) string {
if name == "" {
return ""
}
switch {
case namespace != "" && subsystem != "":
return strings.Join([]string{namespace, subsystem, name}, "_")
case namespace != "":
return strings.Join([]string{namespace, name}, "_")
case subsystem != "":
return strings.Join([]string{subsystem, name}, "_")

sb := strings.Builder{}
sb.Grow(len(namespace) + len(subsystem) + len(name) + 2)

if namespace != "" {
sb.WriteString(namespace)
sb.WriteString("_")
}
return name

if subsystem != "" {
sb.WriteString(subsystem)
sb.WriteString("_")
}

sb.WriteString(name)

return sb.String()
}

type invalidMetric struct {
Expand Down