Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alertmanager] Variable to add extra Pod Configurations #4845

Conversation

rakesh-von
Copy link
Contributor

@rakesh-von rakesh-von commented Sep 10, 2024

What this PR does / why we need it

This PR lets users add additional Pod configs such as dnsPolicy and hostNetwork

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@rakesh-von rakesh-von force-pushed the feature/alertmanager_extrapodconfigs branch from 25c9f3c to 3c92c6e Compare September 10, 2024 13:40
@rakesh-von
Copy link
Contributor Author

@monotek - can you please review this change? We need this on an urgent basis. Sorry for this urgency.

@rakesh-von
Copy link
Contributor Author

Hi @naseemkullah - can you please review this PR?

Copy link
Member

@dongjiang1989 dongjiang1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakesh-von
Copy link
Contributor Author

HI @dongjiang1989 - thanks for reviewing, is it possible for you to merge this please?

@rakesh-von
Copy link
Contributor Author

@monotek and @naseemkullah - can you please review this please? we are waiting for this change.

@monotek monotek merged commit 0dafd6e into prometheus-community:main Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants