allow components as a positional argument again #2488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #2485
I missed this in the code review. I think "components" should also be allowed as a positional argument. Thats at least how I usually use it when playing around. My mental model is that "model" and "components" are required arguments, which should always be provided and the other arguments can be provided, but in no specific order. The counter argument is that components also have a default value ("default"), so my mental model is not fully correct since its not strictly required. @quaquel whats your stance on this?