Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove place_agent duplicate warnings #2086

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

rht
Copy link
Contributor

@rht rht commented Mar 24, 2024

Because of #2083, some faulty test code have been caught. cc: @puer-robustus

@rht rht force-pushed the fix_test branch 2 times, most recently from df54bbe to 8267299 Compare March 24, 2024 00:14
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.0% [-0.3%, +0.4%] 🔵 -0.1% [-0.3%, +0.1%]
Schelling large 🔵 -0.2% [-0.8%, +0.3%] 🔵 +0.6% [+0.2%, +0.9%]
WolfSheep small 🔵 +0.1% [-0.7%, +0.9%] 🔵 +0.1% [-0.2%, +0.3%]
WolfSheep large 🔵 -0.1% [-0.5%, +0.2%] 🔵 -0.3% [-0.5%, -0.1%]
BoidFlockers small 🔵 +0.1% [-0.4%, +0.7%] 🔵 +0.7% [+0.1%, +1.4%]
BoidFlockers large 🔵 +0.6% [+0.3%, +0.9%] 🔵 +1.1% [+0.6%, +1.6%]

@EwoutH
Copy link
Member

EwoutH commented Mar 24, 2024

Can you split of the ruff update in a separate PR? I like to keep PRs atomic.

@rht
Copy link
Contributor Author

rht commented Mar 24, 2024

Done.

@EwoutH
Copy link
Member

EwoutH commented Mar 24, 2024

Thanks! I guess it isn’t allowed in current Mesa to initialize agents with a pos right? I have seen it in other models, maybe we should write that up somewhere.

Also, which warning is this removing exactly?

@rht rht added trigger-benchmarks Special label that triggers the benchmarking CI and removed trigger-benchmarks Special label that triggers the benchmarking CI labels Mar 24, 2024
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.1% [-0.1%, +0.3%] 🔵 +0.5% [+0.4%, +0.7%]
Schelling large 🔵 -0.0% [-0.4%, +0.5%] 🔵 +0.2% [-0.2%, +0.9%]
WolfSheep small 🔵 +0.7% [-0.3%, +1.7%] 🔵 +1.2% [+1.1%, +1.4%]
WolfSheep large 🔵 -0.0% [-0.4%, +0.4%] 🔵 +1.7% [+1.3%, +2.1%]
BoidFlockers small 🟢 -88.0% [-88.1%, -87.9%] 🔵 -2.7% [-3.4%, -2.0%]
BoidFlockers large 🟢 -87.9% [-88.0%, -87.9%] 🔵 -1.5% [-2.1%, -0.8%]

@rht
Copy link
Contributor Author

rht commented Mar 24, 2024

Thanks! I guess it isn’t allowed in current Mesa to initialize agents with a pos right?

Allowed but not recommended.

Also, which warning is this removing exactly?

#2083

@rht rht merged commit 4eef2be into projectmesa:main Mar 24, 2024
13 checks passed
@EwoutH EwoutH added the testing Release notes label label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants