add engine params to engine API #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMGS
reviewed
Jul 7, 2024
CMGS
reviewed
Jul 7, 2024
utils/cache.go
Outdated
| @@ -39,3 +39,12 @@ func (c *EngineCache) Get(endpoint string) engine.API { | |||
| func (c *EngineCache) Delete(host string, _ ...string) { | |||
| c.cache.Delete(host) | |||
| } | |||
|
|
|||
| func (c *EngineCache) Items() map[string]engine.API { | |||
There was a problem hiding this comment.
这个主要是为了保持一致，因为这个地方在go-cache包一层就是为了不用直接搞any，不过确实可以拿掉，少一次遍历，我其实想把这里的cache换成haxmap，cache主要的用途就是那个自动过期清理，但是按现在的实现代码已经明确清理了无效的engine，cache这个功能没啥必要了，而且ForEach遍历的时候就只遍历一次，go-cache用items来每一次都要遍历2次
There was a problem hiding this comment.
我觉得你第二个思路可以……主要是吧，不想把 engine 内部细节暴露到外层来
|
UT主要还是是那个并发的问题 |
CMGS
reviewed
Jul 7, 2024
engine/factory/factory.go
Outdated
| } | ||
|
|
||
| // Get . | ||
| func (e *EngineCache) Get(key string) engine.API { | ||
| return e.cache.Get(key) | ||
| if api, found := e.cache.Get(key); found { |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enginefactory has two map, cache is cache key to engine API and keysToCheck is cache key to engineParams. this pr mainly does 2 things: