enable revive, fix all warnings

cluster/calcium/create.go

@@ -153,7 +153,7 @@ func (c *Calcium) doCreateWorkloads(ctx context.Context, opts *types.DeployOptio
 					return
 				}
 				for nodename, rollbackIndices := range rollbackMap {
-					if e := c.withNodePodLocked(ctx, nodename, func(ctx context.Context, node *types.Node) error {
+					if e := c.withNodePodLocked(ctx, nodename, func(ctx context.Context, _ *types.Node) error {
 						rollbackResources := utils.Map(rollbackIndices, func(idx int) resourcetypes.Resources {
 							return workloadResourcesMap[nodename][idx]
 						})

cluster/calcium/create_test.go

@@ -247,7 +247,7 @@ func TestCreateWorkloadTxn(t *testing.T) {
 	engine.AssertExpectations(t)
 }
 
-func newCreateWorkloadCluster(t *testing.T) (*Calcium, []*types.Node) {
+func newCreateWorkloadCluster(_ *testing.T) (*Calcium, []*types.Node) {
 	c := NewTestCluster()
 
 	engine := &enginemocks.API{}

cluster/calcium/node.go

@@ -99,7 +99,7 @@ func (c *Calcium) RemoveNode(ctx context.Context, nodename string) error {
 				return nil
 			},
 			// rollback: do nothing
-			func(ctx context.Context, failureByCond bool) error {
+			func(_ context.Context, _ bool) error {
 				return nil
 			},
 			c.config.GlobalTimeout)

cluster/calcium/pod.go

@@ -31,7 +31,7 @@ func (c *Calcium) RemovePod(ctx context.Context, podname string) error {
 		Podname: podname,
 		All:     true,
 	}
-	return c.withNodesPodLocked(ctx, nodeFilter, func(ctx context.Context, nodes map[string]*types.Node) error {
+	return c.withNodesPodLocked(ctx, nodeFilter, func(ctx context.Context, _ map[string]*types.Node) error {
 		// TODO dissociate workload to node
 		// TODO should remove node first
 		err := c.store.RemovePod(ctx, podname)

cluster/calcium/sendlarge.go

@@ -20,7 +20,7 @@ func (c *Calcium) SendLargeFile(ctx context.Context, inputChan chan *types.SendL
 		senders := make(map[string]*workloadSender)
 		// for each file
 		for data := range inputChan {
-			for _, id := range data.Ids {
+			for _, id := range data.IDs {
 				if _, ok := senders[id]; !ok {
 					log.Debugf(ctx, "[SendLargeFile] create sender for %s", id)
 					// for each container, let's create a new sender to send identical file chunk, each chunk will include the metadata of this file

cluster/calcium/sendlarge_test.go

@@ -23,7 +23,7 @@ func TestSendLarge(t *testing.T) {
 	defer os.RemoveAll(tmpfile.Name())
 	defer tmpfile.Close()
 	opts := &types.SendLargeFileOptions{
-		Ids:   []string{"cid"},
+		IDs:   []string{"cid"},
 		Size:  1,
 		Dst:   "/tmp/1",
 		Chunk: []byte{},

core.go

@@ -137,7 +137,7 @@ func serve(c *cli.Context) error {
 }
 
 func main() {
-	cli.VersionPrinter = func(c *cli.Context) {
+	cli.VersionPrinter = func(_ *cli.Context) {
 		fmt.Print(version.String())
 	}
 

engine/factory/factory.go

@@ -101,7 +101,7 @@ func (e *EngineCache) CheckAlive(ctx context.Context) {
 
 		paramsChan := make(chan engineParams)
 		go func() {
-			e.keysToCheck.ForEach(func(k string, v engineParams) bool {
+			e.keysToCheck.ForEach(func(_ string, v engineParams) bool {
 				paramsChan <- v
 				return true
 			})
@@ -169,7 +169,7 @@ func (e *EngineCache) CheckNodeStatus(ctx context.Context) {
 				continue
 			}
 			// a node may have multiple engines, so we need check all key here
-			e.keysToCheck.ForEach(func(k string, ep engineParams) bool {
+			e.keysToCheck.ForEach(func(_ string, ep engineParams) bool {
 				if ep.nodename == ns.Nodename {
 					logger.Infof(ctx, "remove engine %+v from cache", ep.getCacheKey())
 					RemoveEngineFromCache(ctx, ep.endpoint, ep.ca, ep.cert, ep.key)

resource/cobalt/alloc.go

@@ -77,7 +77,7 @@ func (m Manager) Alloc(ctx context.Context, nodename string, deployCount int, op
 			return nil
 		},
 		// rollback: do nothing
-		func(ctx context.Context) error {
+		func(_ context.Context) error {
 			return nil
 		},
 		m.config.GlobalTimeout,

resource/cobalt/node.go

@@ -25,7 +25,7 @@ func (m Manager) AddNode(ctx context.Context, nodename string, opts resourcetype
 
 	return res, utils.PCR(ctx,
 		// prepare: do nothing
-		func(ctx context.Context) error {
+		func(_ context.Context) error {
 			return nil
 		},
 		// commit: call plugins to add the node
@@ -224,7 +224,7 @@ func (m Manager) SetNodeResourceUsage(ctx context.Context, nodename string, node
 	after := resourcetypes.Resources{}
 
 	return before, after, utils.PCR(ctx,
-		func(ctx context.Context) error {
+		func(_ context.Context) error {
 			// prepare: covert []resourcetypes.Resources to map[plugin]resourcetypes.Resources
 			// [{"cpu-plugin": {"cpu": 1}}, {"cpu-plugin": {"cpu": 1}}] -> {"cpu-plugin": [{"cpu": 1}, {"cpu": 1}]}
 			for _, workloadResource := range workloadsResource {
@@ -319,7 +319,7 @@ func (m Manager) SetNodeResourceCapacity(ctx context.Context, nodename string, n
 	after := resourcetypes.Resources{}
 
 	return before, after, utils.PCR(ctx,
-		func(ctx context.Context) error {
+		func(_ context.Context) error {
 			if nodeResourceRequest == nil {
 				nodeResourceRequest = resourcetypes.Resources{}
 			}

resource/cobalt/realloc.go

@@ -54,7 +54,7 @@ func (m Manager) Realloc(ctx context.Context, nodename string, nodeResource reso
 			return nil
 		},
 		// rollback: do nothing
-		func(ctx context.Context) error {
+		func(_ context.Context) error {
 			return nil
 		},
 		m.config.GlobalTimeout,

resource/plugins/cpumem/schedule/schedule.go

@@ -282,15 +282,15 @@ func (h *host) getFullCPUPlans(cores []*cpuCore, full int) []types.CPUMap {
 	}
 
 	// Try to ensure the effectiveness of the previous priority
-	sumOfIds := func(c types.CPUMap) int {
+	sumOfIDs := func(c types.CPUMap) int {
 		sum := 0
 		for ID := range c {
 			sum += indexMap[ID]
 		}
 		return sum
 	}
 
-	sort.Slice(result, func(i, j int) bool { return sumOfIds(result[i]) < sumOfIds(result[j]) })
+	sort.Slice(result, func(i, j int) bool { return sumOfIDs(result[i]) < sumOfIDs(result[j]) })
 
 	return result
 }

rpc/transform.go

@@ -587,7 +587,7 @@ func toCoreListImageOptions(opts *pb.ListImageOptions) *types.ImageOptions {
 
 func toSendLargeFileOptions(opts *pb.FileOptions) (*types.SendLargeFileOptions, error) {
 	ret := &types.SendLargeFileOptions{
-		Ids:   opts.Ids,
+		IDs:   opts.Ids,
 		Dst:   opts.Dst,
 		Size:  opts.Size,
 		Mode:  opts.Mode.Mode,
@@ -604,7 +604,7 @@ func toSendLargeFileChunks(file types.LinuxFile, ids []string) []*types.SendLarg
 	ret := make([]*types.SendLargeFileOptions, 0)
 	for idx := 0; idx < len(file.Content); idx += maxChunkSize {
 		sendLargeFileOptions := &types.SendLargeFileOptions{
-			Ids:  ids,
+			IDs:  ids,
 			Dst:  file.Filename,
 			Size: int64(len(file.Content)),
 			Mode: file.Mode,

types/options.go

@@ -308,7 +308,7 @@ const SendLargeFileChunkSize = 2 << 10
 
 // SendLargeFileOptions for LargeFileTransfer
 type SendLargeFileOptions struct {
-	Ids   []string
+	IDs   []string
 	Dst   string
 	Size  int64
 	Mode  int64
@@ -319,7 +319,7 @@ type SendLargeFileOptions struct {
 
 // Validate checks options
 func (o *SendLargeFileOptions) Validate() error {
-	if len(o.Ids) == 0 {
+	if len(o.IDs) == 0 {
 		return ErrNoWorkloadIDs
 	}
 	if len(o.Chunk) == 0 {