Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I2c s3 #134

Merged
merged 2 commits into from
Jul 3, 2024
Merged

I2c s3 #134

merged 2 commits into from
Jul 3, 2024

Conversation

ljia5
Copy link

@ljia5 ljia5 commented Jun 23, 2024

No description provided.

@sysopenci
Copy link

Improper Commit Message
Proper Tracked on value is not present in
commit message,make sure Tracked-on: jira-ticket is present

@sysopenci
Copy link

Improper Commit Message
Proper Tracked on value is not present in
commit message,make sure Tracked-on: jira-ticket is present

@ljia5 ljia5 requested review from feijiang1 and phreer and removed request for feijiang1, gkdeepa, JeevakaPrabu, kaushlen, sgnanase, shyjumon-n and xzhan34 June 28, 2024 08:54
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

phreer
phreer reviewed Jun 28, 2024
View reviewed changes
Copy link

@phreer phreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR fix the issue when doing cold boot?

drivers/gpu/drm/bridge/ti/fpd_dp_ser_drv.c Outdated Show resolved Hide resolved
drivers/gpu/drm/bridge/ti/fpd_dp_ser_drv.c Show resolved Hide resolved
drivers/input/touchscreen/ef1e_tp/ef1e_tp_driver.c Show resolved Hide resolved
phreer
phreer approved these changes Jul 3, 2024
View reviewed changes
Copy link

@phreer phreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ljia5
drm/bridge: Fix i2c timeout issue
813aefb 
1.Modify 983 register setting to avoid i2c timeout error
2.Set delay before 983/984 reset operation
3.Change ser_ready/deser_reset flag
4.Move reload registers to resume_early
5.Remove 983/984 reset in suspend

Test-done:
Android boot/suspend tested with panel EF1E-A1

Tracked-On: OAM-121472
Signed-off-by: Jia, Lin A [email protected]
@feijiang1
Copy link

It is better you run scripts/checkpatch.pl to verify your patch doesn't have coding style problem.

@ljia5
drm/bridge: Add serdes/touch shutdown function
6b521f8 
1. Add serdes shutdown fucntion
2. Add ef1e shutdown function
3. Remove workqueue in serdes
4. Change 983/984 400k i2c speed
5. Retry i2c write if write fail

Test-done:
    Android s3/s5 tested with panel EF1E-A1

Tracked-On: OAM-121472
Signed-off-by: Jia, Lin A <[email protected]>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

1 similar comment
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Failed and removed Engineering Build Successful Engineering Build Successful labels Jul 3, 2024
feijiang1
feijiang1 approved these changes Jul 3, 2024
View reviewed changes
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Failed labels Jul 3, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 08e6bcf into projectceladon:celadon/s/mr0/apollo Jul 3, 2024
15 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_smr0_apollo-merge/199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phreer phreer phreer approved these changes

@feijiang1 feijiang1 feijiang1 approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljia5 @sysopenci @feijiang1 @phreer